fix(ftw): preserve auxiliary expert banks - #317
Open
ErikBPF wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve expert banks that use a different quant format or row geometry from the primary bank set during FTW conversion and load. Without this, converting a heterogeneous expert layout silently writes only the primary banks.
ExpertBanksProvider-specific Qwen loading is intentionally separate; this PR contains only the generic FTW preservation mechanism.
Tests
git diff --checkpassFull-model evidence
Matched Orion ROCm runs used 8,192-token context, 1,024 output tokens, concurrency 4, 3 rounds, and 12 requests per format:
All 24 requests finished by length. Every GGUF and FTW output matched SHA-256
1ec7793ebf17b06a81148a198b7fbb5e5a68018c75982dd123cb1cf0fc2b8860. Both formats used 2,073 expert slots, 8,219 KV pages, and retained 7.71 GiB free after initialization.The primary claim is exact conversion/load preservation. The observed +1.56% decode difference is secondary.